-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make BackendSampler set shots and stddev_upper_bound of returned QuasiDistribution #9312
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shots setting LGTM, but I'm less sure about the stddev_upper_bound
since 1/N is only the asymptotic behavior, right? As the reference Sampler also doesn't set this I would be happy to merge without the stddev_upper_bound
-- otherwise maybe someone more familiar with the QuasiDistribution
class can have a look 🙂
The logic for Maybe @t-imamichi or @nonhermitian can comment on the correctness. The |
Ok, but if it were a bound on the stddev of the |
Consider a quantum state
In your comment above you refer to (1), but |
Because the output can be a quasi-distribution with negative values one cannot use standard variance formulas. One can however get an upper-bound on this as described here: https://arxiv.org/abs/2006.14044, |
In this case it's a probability distribution though, since it's calculated as |
Yeah for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I forgot reviewing. LGTM. In this case, gamma is always 1, so this definition of the upper bound of standard deviation is correct.
Just one comment: this is not a bug, but enhancement.
Pull Request Test Coverage Report for Build 3951860569
💛 - Coveralls |
Summary
Fixes #9311
Details and comments